I reckon a suit, and much modern clothing in general, doesn't do any favours in the eye candy department, and also (for those who lived through the eighties) that excessive make-up doesn't either, so I don't think that's the most flattering shot of Mr Smith!
I was thinking about this attractiveness topic, and actually the haircut seems to figure greatly, at least for me. If it's too short it doesn't work. Mentally do a No.1 army cut on Matt Smith, does it make a difference? David Tennant also had a good haircut, not too short.
And then there's Viggo Mortensen, who was clearly eye candy as Strider / Aragorn in Lord of the Rings
, with his long hair and medieval clothes. But compare that to him short and blond in other photos, it's like chalk and cheese!
So, for me anyway, healthy athletic body plus longish to long, well-maintained, natural-looking hair plus some sort of classical / medieval clothing seems to be a good formula for visual admiration of a male specimen.